JiXieShi/SerialTerminalForWindowsTerminal
1
0
Fork 0
mirror of https://github.com/jixishi/SerialTerminalForWindowsTerminal.git synced 2026-06-16 00:52:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: TUI 'g' key input, EndStr panel editing, and mode validation

Browse Source 
- Remove 'g' and 'shift+g' from viewport handler (conflicted with
  text input; home/end keys already provide same functionality)
- Add rawValue field to modeItem to preserve EndStr control chars
  during TUI panel editing (fixes %q round-trip corruption)
- Add validation for empty charset names and timefmt fields

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
JiXieShi
2026-05-23 22:25:47 +08:00
parent 84cda89d1d
commit daad844d4f
4 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/termapp/tui_panels.go
+9 -2
View File
@@ -71,7 +71,14 @@ func (m *uiModel) refreshPanel() {
}
func (m *uiModel) buildModeItems() []modeItem {
return []modeItem{{"in", "Input Charset", m.app.cfg.InputCode}, {"out", "Output Charset", m.app.cfg.OutputCode}, {"end", "Line End", fmt.Sprintf("%q", m.app.cfg.EndStr)}, {"frame", "Hex Frame Size", fmt.Sprintf("%d", m.app.cfg.FrameSize)}, {"timestamp", "Timestamp", fmt.Sprintf("%v", m.app.cfg.TimesTamp)}, {"timefmt", "Timestamp Format", m.app.cfg.TimesFmt}}
return []modeItem{
{"in", "Input Charset", m.app.cfg.InputCode, m.app.cfg.InputCode},
{"out", "Output Charset", m.app.cfg.OutputCode, m.app.cfg.OutputCode},
{"end", "Line End", fmt.Sprintf("%q", m.app.cfg.EndStr), m.app.cfg.EndStr},
{"frame", "Hex Frame Size", fmt.Sprintf("%d", m.app.cfg.FrameSize), fmt.Sprintf("%d", m.app.cfg.FrameSize)},
{"timestamp", "Timestamp", fmt.Sprintf("%v", m.app.cfg.TimesTamp), fmt.Sprintf("%v", m.app.cfg.TimesTamp)},
{"timefmt", "Timestamp Format", m.app.cfg.TimesFmt, m.app.cfg.TimesFmt},
}
}
func (m *uiModel) handleForwardPanelKey(key string) bool {
@@ -222,7 +229,7 @@ func (m *uiModel) handleModePanelKey(key string) bool {
}
return true
case "enter", "e":
initial := strings.Trim(sel.value, "\"")
initial := sel.rawValue
m.startPrompt("Edit Mode: "+sel.label, "new value", initial, func(v string) {
m.app.handleLine(fmt.Sprintf(".mode set %s %s", sel.key, v))
m.refreshPanel()