JiXieShi/SerialTerminalForWindowsTerminal
1
0
Fork 0
mirror of https://github.com/jixishi/SerialTerminalForWindowsTerminal.git synced 2026-06-16 00:52:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: extract internal/config and eliminate global config var

Browse Source 
Move Config struct to internal/config with exported fields. Replace
global var config with package-level cfg pointer. Add OpenLogFile to
config package. Add type alias Config = appconfig.Config in main
package for backward compatibility.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
JiXieShi
2026-05-23 21:45:08 +08:00
parent 2ce672cdde
commit 31dd9da490
15 changed files with 198 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app_test.go
+8 -11
View File
@@ -61,7 +61,7 @@ func TestAppUIEvents(t *testing.T) {
func TestSendLine(t *testing.T) {
setupTestPipes()
a := &App{
cfg: &Config{endStr: "\r\n"},
cfg: &Config{EndStr: "\r\n"},
plugins: luaplugin.NewManager(),
uiEvents: make(chan event.UIEvent, 8),
done: make(chan struct{}),
@@ -83,7 +83,7 @@ func TestSendLine(t *testing.T) {
func TestHandleLine(t *testing.T) {
setupTestPipes()
a := &App{
cfg: &Config{endStr: "\n", inputCode: "UTF-8", outputCode: "UTF-8"},
cfg: &Config{EndStr: "\n", InputCode: "UTF-8", OutputCode: "UTF-8"},
plugins: luaplugin.NewManager(),
uiEvents: make(chan event.UIEvent, 8),
done: make(chan struct{}),
@@ -159,22 +159,19 @@ func TestAppClose(t *testing.T) {
}
func TestLoadConfiguredForwards(t *testing.T) {
oldCfg := config
defer func() { config = oldCfg }()
listener, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatalf("listen failed: %v", err)
}
defer listener.Close()
config = Config{
forWard: []int{int(forward.TCP), int(forward.None), int(forward.UDP)},
address: []string{listener.Addr().String(), "", ""},
testCfg := &Config{
ForWard: []int{int(forward.TCP), int(forward.None), int(forward.UDP)},
Address: []string{listener.Addr().String(), "", ""},
}
a := &App{
cfg: &config,
cfg: testCfg,
forward: forward.NewManager(func([]byte) error { return nil }, func(string, ...any) {}),
uiEvents: make(chan event.UIEvent, 8),
done: make(chan struct{}),
@@ -191,7 +188,7 @@ func TestLoadConfiguredForwards(t *testing.T) {
func TestReportForwardIngress(t *testing.T) {
a := &App{
cfg: &Config{inputCode: "UTF-8", outputCode: "UTF-8"},
cfg: &Config{InputCode: "UTF-8", OutputCode: "UTF-8"},
uiEvents: make(chan event.UIEvent, 4),
}
a.SetUIEnabled(true)
@@ -199,7 +196,7 @@ func TestReportForwardIngress(t *testing.T) {
a.reportForwardIngress(1, []byte("test"))
// Hex mode
a.cfg.inputCode = "hex"
a.cfg.InputCode = "hex"
a.reportForwardIngress(2, []byte{0x41, 0x42})
// Empty chunk